Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/5209#discussion_r27274404
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -49,12 +49,17 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext, scheduler: TaskSchedule
// executor ID -> timestamp of when the last heartbeat from this
executor was received
private val executorLastSeen = new mutable.HashMap[String, Long]
-
- private val executorTimeoutMs = sc.conf.getLong("spark.network.timeout",
- sc.conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120)) *
1000
-
- private val checkTimeoutIntervalMs =
sc.conf.getLong("spark.network.timeoutInterval",
- sc.conf.getLong("spark.storage.blockManagerTimeoutIntervalMs", 60)) *
1000
+
+ // `spark.network.timeout` use `seconds`,
--- End diff --
Minor nits on the comments:
* I wouldn't use backticks here because it's not md-formatted.
* "use" -> "uses"
* "while" should be on line above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
