agrawaldevesh commented on a change in pull request #29014:
URL: https://github.com/apache/spark/pull/29014#discussion_r457776437
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -912,13 +914,39 @@ private[spark] class TaskSchedulerImpl(
}
}
- override def executorDecommission(executorId: String): Unit = {
+ override def executorDecommission(
+ executorId: String, decommissionInfo: ExecutorDecommissionInfo): Unit = {
+ synchronized {
Review comment:
That would be a bug: isHostDecommissioned is ultimately decided by the
cluster manager. It knows for sure whether or not the host is decommissioned
with the executor. It shouldn't change its mind :-). I can add an assert in the
Driver but it would be a bit of an overkill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
