agrawaldevesh commented on a change in pull request #29014:
URL: https://github.com/apache/spark/pull/29014#discussion_r457778416
##########
File path:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala
##########
@@ -245,8 +249,8 @@ class AppClientSuite
execRemovedList.add(id)
}
- def executorDecommissioned(id: String, message: String): Unit = {
- execDecommissionedList.add(id)
+ def executorDecommissioned(id: String, decommissionInfo:
ExecutorDecommissionInfo): Unit = {
+ execDecommissionedMap.putIfAbsent(id, decommissionInfo)
Review comment:
Yeah I should probably have stronger checks here considering that this
is a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
