rednaxelafx commented on a change in pull request #29407:
URL: https://github.com/apache/spark/pull/29407#discussion_r468936303



##########
File path: core/src/test/scala/org/apache/spark/util/SizeEstimatorSuite.scala
##########
@@ -214,6 +216,10 @@ class SizeEstimatorSuite
   }
 
   test("class field blocks rounding on 64-bit VM without useCompressedOops") {
+    System.setProperty(TEST_USE_COMPRESSED_OOPS_KEY, "false")

Review comment:
       Since this PR is all about explicit re-initialization, should we add 
`System.setProperty("os.arch", "amd64")` to this block as well?
   Actually would it be a good idea to wrap this sequence into a helper method 
or something?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to