rednaxelafx commented on a change in pull request #29407:
URL: https://github.com/apache/spark/pull/29407#discussion_r469502620



##########
File path: core/src/test/scala/org/apache/spark/util/SizeEstimatorSuite.scala
##########
@@ -214,6 +216,10 @@ class SizeEstimatorSuite
   }
 
   test("class field blocks rounding on 64-bit VM without useCompressedOops") {
+    System.setProperty(TEST_USE_COMPRESSED_OOPS_KEY, "false")

Review comment:
       In which case it'd be better to keep all the relevant test cases 
consistent by removing those explicit initialization lines in a couple of other 
test cases in the same file?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to