Ngone51 commented on a change in pull request #29228:
URL: https://github.com/apache/spark/pull/29228#discussion_r474386809
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -235,7 +235,7 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with TimeLi
_endedTasks.toSet
}
- private def waitForListeners(): Unit = sc.listenerBus.waitUntilEmpty()
+ private def waitForListeners(): Unit =
sparkCtx.listenerBus.waitUntilEmpty()
Review comment:
I'm thinking if we could have a new copy of `LocalSparkContext`, e.g.,
`LocalSC`, then, we don't need to change from `sc` to `sparkCtx`? And for other
test suites, we only need to replace `LocalSparkContext` with `LocalSC`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
