Ngone51 commented on a change in pull request #29228:
URL: https://github.com/apache/spark/pull/29228#discussion_r474417504
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -3242,14 +3241,16 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with TimeLi
val treqs2 = new TaskResourceRequests().cpus(2)
val rp2 = new
ResourceProfileBuilder().require(ereqs2).require(treqs2).build
- val rdd = sc.parallelize(1 to 10).withResources(rp1).map(x => (x,
x)).withResources(rp2)
+ val rdd = sc.parallelize(1 to 10)
+ .withResources(rp1).map(x => (x, x)).withResources(rp2)
Review comment:
ditto
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -3242,14 +3241,16 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with TimeLi
val treqs2 = new TaskResourceRequests().cpus(2)
val rp2 = new
ResourceProfileBuilder().require(ereqs2).require(treqs2).build
- val rdd = sc.parallelize(1 to 10).withResources(rp1).map(x => (x,
x)).withResources(rp2)
+ val rdd = sc.parallelize(1 to 10)
+ .withResources(rp1).map(x => (x, x)).withResources(rp2)
val (_, resourceprofiles) =
scheduler.getShuffleDependenciesAndResourceProfiles(rdd)
val mergedRp = scheduler.mergeResourceProfilesForStage(resourceprofiles)
assert(mergedRp.getTaskCpus.get == 2)
assert(mergedRp.getExecutorCores.get == 4)
// test that instead of creating a new merged profile, we use the already
created one
- val rdd2 = sc.parallelize(1 to 10).withResources(rp1).map(x => (x,
x)).withResources(rp2)
+ val rdd2 =
+ sc.parallelize(1 to 10).withResources(rp1).map(x => (x,
x)).withResources(rp2)
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
