Ngone51 commented on a change in pull request #29228:
URL: https://github.com/apache/spark/pull/29228#discussion_r474417075



##########
File path: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -1104,7 +1104,8 @@ class DAGSchedulerSuite extends SparkFunSuite with 
LocalSparkContext with TimeLi
 
     val shuffleOneRdd = new MyRDD(sc, 2, Nil).cache()
     val shuffleDepOne = new ShuffleDependency(shuffleOneRdd, new 
HashPartitioner(2))
-    val shuffleTwoRdd = new MyRDD(sc, 2, List(shuffleDepOne), tracker = 
mapOutputTracker).cache()
+    val shuffleTwoRdd =
+      new MyRDD(sc, 2, List(shuffleDepOne), tracker = mapOutputTracker).cache()

Review comment:
       unnecessary change?

##########
File path: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -1153,7 +1154,8 @@ class DAGSchedulerSuite extends SparkFunSuite with 
LocalSparkContext with TimeLi
 
     val shuffleOneRdd = new MyRDD(sc, 2, Nil).cache()
     val shuffleDepOne = new ShuffleDependency(shuffleOneRdd, new 
HashPartitioner(2))
-    val shuffleTwoRdd = new MyRDD(sc, 2, List(shuffleDepOne), tracker = 
mapOutputTracker).cache()
+    val shuffleTwoRdd =
+      new MyRDD(sc, 2, List(shuffleDepOne), tracker = mapOutputTracker).cache()

Review comment:
       ditto

##########
File path: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -1757,7 +1759,8 @@ class DAGSchedulerSuite extends SparkFunSuite with 
LocalSparkContext with TimeLi
     val shuffleDep2 = new ShuffleDependency(shuffleMapRdd2, new 
HashPartitioner(2))
 
     val reduceRdd1 = new MyRDD(sc, 2, List(shuffleDep1), tracker = 
mapOutputTracker)
-    val reduceRdd2 = new MyRDD(sc, 2, List(shuffleDep1, shuffleDep2), tracker 
= mapOutputTracker)
+    val reduceRdd2 =
+      new MyRDD(sc, 2, List(shuffleDep1, shuffleDep2), tracker = 
mapOutputTracker)

Review comment:
       ditto

##########
File path: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -1954,7 +1957,8 @@ class DAGSchedulerSuite extends SparkFunSuite with 
LocalSparkContext with TimeLi
   test("cached post-shuffle") {
     val shuffleOneRdd = new MyRDD(sc, 2, Nil).cache()
     val shuffleDepOne = new ShuffleDependency(shuffleOneRdd, new 
HashPartitioner(2))
-    val shuffleTwoRdd = new MyRDD(sc, 2, List(shuffleDepOne), tracker = 
mapOutputTracker).cache()
+    val shuffleTwoRdd =
+      new MyRDD(sc, 2, List(shuffleDepOne), tracker = mapOutputTracker).cache()

Review comment:
       ditto




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to