Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5350#discussion_r27766676
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala
 ---
    @@ -59,6 +60,10 @@ class ExpressionEvaluationBaseSuite extends FunSuite {
     
     class ExpressionEvaluationSuite extends ExpressionEvaluationBaseSuite {
     
    +  def create_row(values: Any*): Row = {
    +    new GenericRow(values.map(ScalaReflection.convertToCatalyst).toArray)
    --- End diff --
    
    Yes, that's also the thing I had considered. Once the Row is accessible 
from user, we can not use UTF8Sting inside it. For catalyst tests, we should do 
the conversion manually. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to