Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5350#discussion_r28011147
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DateUtils.scala ---
@@ -39,6 +39,8 @@ object DateUtils {
millisToDays(d.getTime)
}
+ // TODO(davies): This is buggy, it will be wrong if the date is not
aligned with day
+ // we should use the exact day as Int, for example, (year, month, day)
-> day
--- End diff --
Please open a jira for it. Also, add an example to explain the problem if
you think the `TODO` at here is necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
