Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5350#discussion_r28010239
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -85,8 +85,10 @@ case class UserDefinedGenerator(
override protected def makeOutput(): Seq[Attribute] = schema
override def eval(input: Row): TraversableOnce[Row] = {
+ // TODO(davies): improve this
+ val input_schema = StructType(children.map(e =>
StructField(e.simpleString, e.dataType, true)))
--- End diff --
Can you explain what is the problem at here? Why we need to do the get the
input schema in the `eval`? Also, `inputSchema` seems better than
`input_schema`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
