Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5428#discussion_r28085485
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala ---
@@ -77,7 +77,8 @@ object Checkpoint extends Logging {
}
/** Get checkpoint files present in the give directory, ordered by
oldest-first */
- def getCheckpointFiles(checkpointDir: String, fs: FileSystem): Seq[Path]
= {
+ def getCheckpointFiles(checkpointDir: String, fsOption:
Option[FileSystem] = None): Seq[Path] = {
--- End diff --
This change seems unrelated to this fix. I think we can simply do a null
check inside this method and create a FileSystem if needed to avoid unnecessary
changes to the calls (all the fs being passed in changing to Some(fs)) -- keeps
git history sane.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
