Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5428#discussion_r28086500
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -114,11 +123,15 @@ class StreamingContext private[streaming] (
private[streaming] val isCheckpointPresent = (cp_ != null)
+ private[streaming] val isSparkContextPresent = (sc_ != null)
--- End diff --
This seems to have been defined for setting `sc` below, but once `sc` is
set this variable can be false, while `sc` is no longer `null`. This `val`
should probably not be added, else we risk ending up having bugs caused by this
being `false` which it can never be, since a spark context is always present.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
