AngersZhuuuu commented on pull request #30131:
URL: https://github.com/apache/spark/pull/30131#issuecomment-715889934


   > if there is heavy gc after sending rpc request, but before task completes 
- fixed delay will be gc time + wait time vs just wait time.
   
   Double check the code of `ScheduleFutureTask`
   ```
   public void run() {
               boolean periodic = isPeriodic();
               if (!canRunInCurrentRunState(periodic))
                   cancel(false);
               else if (!periodic)
                   ScheduledFutureTask.super.run();
               else if (ScheduledFutureTask.super.runAndReset()) {
                   setNextRunTime();
                   reExecutePeriodic(outerTask);
               }
           }
   ```
   `resetNextRunTime` called before executing scheduled task. So the real 
interval between two task should be max(gd time + fixed delay , fixed delay)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to