mridulm commented on pull request #30131: URL: https://github.com/apache/spark/pull/30131#issuecomment-716312657
> > If we want to take a look at the jdk implementation in case the documentation is unclear, please note that both `scheduleAtFixedRate` and `scheduleWithFixedDelay` rely on `ScheduleFutureTask`. > > Yea, I will pay attention to this problem later > > > For (1) above, `time` will be set to `current time` + `period` -> and so delay between tasks is `gc delay` + `period`. > > `gc delay` + `period` should be interval of last task and current task. Use `scheduleAtFixedRate` is same. > > By the way, my fault, in comment [#30131 (comment)](https://github.com/apache/spark/pull/30131#issuecomment-715889934), I mean interval of current task and next task. I have detailed on the behavior change if we go from rate to delay, I am still unclear on why we are making all the changes in this PR. I agree with @Ngone51 that moving periodic gc from rate to delay is good, I am not sure about the rest - can you elaborate why the others are being made ? Any issues resolved/bugs fixed ? If not, limiting to gc change might be good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
