AngersZhuuuu commented on a change in pull request #30131:
URL: https://github.com/apache/spark/pull/30131#discussion_r511735804
##########
File path:
core/src/main/scala/org/apache/spark/executor/ExecutorMetricsPoller.scala
##########
@@ -99,7 +99,7 @@ private[spark] class ExecutorMetricsPoller(
def start(): Unit = {
poller.foreach { exec =>
val pollingTask: Runnable = () => Utils.logUncaughtExceptions(poll())
- exec.scheduleAtFixedRate(pollingTask, 0L, pollingInterval,
TimeUnit.MILLISECONDS)
+ exec.scheduleWithFixedDelay(pollingTask, 0L, pollingInterval,
TimeUnit.MILLISECONDS)
Review comment:
Similar like make GC from rate to delay. It doesn't make sense to
polling twice Immediately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
