Github user cfregly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5439#discussion_r28390845
  
    --- Diff: 
extras/kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala
 ---
    @@ -113,7 +113,7 @@ private object KinesisWordCountASL extends Logging {
         /* Create the same number of Kinesis DStreams/Receivers as Kinesis 
stream's shards */
         val kinesisStreams = (0 until numStreams).map { i =>
           KinesisUtils.createStream(ssc, streamName, endpointUrl, 
kinesisCheckpointInterval,
    -          InitialPositionInStream.LATEST, StorageLevel.MEMORY_AND_DISK_2)
    +          InitialPositionInStream.LATEST, StorageLevel.MEMORY_AND_DISK_2, 
None)
    --- End diff --
    
    would be nice to have a true default here versus adding to the signature


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to