cloud-fan commented on a change in pull request #29339:
URL: https://github.com/apache/spark/pull/29339#discussion_r520692847
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -976,4 +983,24 @@ trait CheckAnalysis extends PredicateHelper {
failOnOuterReferenceInSubTree(p)
}}
}
+
+ // Make sure that table is able to alter partition.
+ private def checkAlterTablePartition(
+ table: Table, parts: Seq[PartitionSpec]): Unit = {
+ (table, parts) match {
+ case (_, parts) if parts.exists(_.isInstanceOf[UnresolvedPartitionSpec])
=>
+ failAnalysis("PartitionSpecs are not resolved")
+
+ case (table, _) if !table.isInstanceOf[SupportsPartitionManagement] =>
+ failAnalysis(s"Table ${table.name()} can not alter partitions.")
+
+ // Skip atomic partition tables
+ case (_: SupportsAtomicPartitionManagement, _) =>
Review comment:
As an example, `TableCatalog.alterTable` accepts a list of `TableChange`
without adding a new atomic API. I don't know why partition API needs to be
different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
