cloud-fan commented on a change in pull request #30297:
URL: https://github.com/apache/spark/pull/30297#discussion_r520547034
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
##########
@@ -255,9 +267,18 @@ case class GetArrayItem(child: Expression, ordinal:
Expression)
} else {
""
}
+
+ val failOnErrorBranch = if (failOnError) {
+ s"""throw new ArrayIndexOutOfBoundsException("Invalid index: " +
$index);""".stripMargin
+ } else {
+ s"${ev.isNull} = true;"
+ }
+
s"""
final int $index = (int) $eval2;
- if ($index >= $eval1.numElements() || $index < 0$nullCheck) {
+ if ($index >= $eval1.numElements() || $index < 0) {
+ $failOnErrorBranch
+ } else if (false$nullCheck) {
Review comment:
OK, we can get rid of the entire `else if (false$nullCheck)` if
`containsNull == false`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
