cloud-fan commented on a change in pull request #30297:
URL: https://github.com/apache/spark/pull/30297#discussion_r520559042



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
##########
@@ -3621,6 +3621,40 @@ class DataFrameFunctionsSuite extends QueryTest with 
SharedSparkSession {
       df.select(map(map_entries($"m"), lit(1))),
       Row(Map(Seq(Row(1, "a")) -> 1)))
   }
+
+  test("SPARK-33391: element_at ArrayIndexOutOfBoundsException") {

Review comment:
       Let's not mix unit test and end-to-end test. Let's add UT in 
`CollectionExpressionsSuite`(for ElementAt)  and `StringExpressionsSuite` (for 
Elt).
   
   For end-to-end test,  we can put them in `DataFrameSuite` for all the three 
functions/operators.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to