cloud-fan commented on a change in pull request #30297:
URL: https://github.com/apache/spark/pull/30297#discussion_r520551420
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -1118,58 +1118,72 @@ class CollectionExpressionsSuite extends SparkFunSuite
with ExpressionEvalHelper
}
test("correctly handles ElementAt nullability for arrays") {
- // CreateArray case
- val a = AttributeReference("a", IntegerType, nullable = false)()
- val b = AttributeReference("b", IntegerType, nullable = true)()
- val array = CreateArray(a :: b :: Nil)
- assert(!ElementAt(array, Literal(1)).nullable)
- assert(!ElementAt(array, Literal(-2)).nullable)
- assert(ElementAt(array, Literal(2)).nullable)
- assert(ElementAt(array, Literal(-1)).nullable)
- assert(!ElementAt(array, Subtract(Literal(2), Literal(1))).nullable)
- assert(ElementAt(array, AttributeReference("ordinal",
IntegerType)()).nullable)
-
- // CreateArray case invalid indices
- assert(!ElementAt(array, Literal(0)).nullable)
- assert(ElementAt(array, Literal(4)).nullable)
- assert(ElementAt(array, Literal(-4)).nullable)
-
- // GetArrayStructFields case
- val f1 = StructField("a", IntegerType, nullable = false)
- val f2 = StructField("b", IntegerType, nullable = true)
- val structType = StructType(f1 :: f2 :: Nil)
- val c = AttributeReference("c", structType, nullable = false)()
- val inputArray1 = CreateArray(c :: Nil)
- val inputArray1ContainsNull = c.nullable
- val stArray1 = GetArrayStructFields(inputArray1, f1, 0, 2,
inputArray1ContainsNull)
- assert(!ElementAt(stArray1, Literal(1)).nullable)
- assert(!ElementAt(stArray1, Literal(-1)).nullable)
- val stArray2 = GetArrayStructFields(inputArray1, f2, 1, 2,
inputArray1ContainsNull)
- assert(ElementAt(stArray2, Literal(1)).nullable)
- assert(ElementAt(stArray2, Literal(-1)).nullable)
-
- val d = AttributeReference("d", structType, nullable = true)()
- val inputArray2 = CreateArray(c :: d :: Nil)
- val inputArray2ContainsNull = c.nullable || d.nullable
- val stArray3 = GetArrayStructFields(inputArray2, f1, 0, 2,
inputArray2ContainsNull)
- assert(!ElementAt(stArray3, Literal(1)).nullable)
- assert(!ElementAt(stArray3, Literal(-2)).nullable)
- assert(ElementAt(stArray3, Literal(2)).nullable)
- assert(ElementAt(stArray3, Literal(-1)).nullable)
- val stArray4 = GetArrayStructFields(inputArray2, f2, 1, 2,
inputArray2ContainsNull)
- assert(ElementAt(stArray4, Literal(1)).nullable)
- assert(ElementAt(stArray4, Literal(-2)).nullable)
- assert(ElementAt(stArray4, Literal(2)).nullable)
- assert(ElementAt(stArray4, Literal(-1)).nullable)
-
- // GetArrayStructFields case invalid indices
- assert(!ElementAt(stArray3, Literal(0)).nullable)
- assert(ElementAt(stArray3, Literal(4)).nullable)
- assert(ElementAt(stArray3, Literal(-4)).nullable)
-
- assert(ElementAt(stArray4, Literal(0)).nullable)
- assert(ElementAt(stArray4, Literal(4)).nullable)
- assert(ElementAt(stArray4, Literal(-4)).nullable)
+ Seq(true, false).foreach { ansiEnabled =>
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> ansiEnabled.toString) {
+ // CreateArray case
+ val a = AttributeReference("a", IntegerType, nullable = false)()
+ val b = AttributeReference("b", IntegerType, nullable = true)()
+ val array = CreateArray(a :: b :: Nil)
+ assert(!ElementAt(array, Literal(1)).nullable)
+ assert(!ElementAt(array, Literal(-2)).nullable)
+ assert(ElementAt(array, Literal(2)).nullable)
+ assert(ElementAt(array, Literal(-1)).nullable)
+ assert(!ElementAt(array, Subtract(Literal(2), Literal(1))).nullable)
+ assert(ElementAt(array, AttributeReference("ordinal",
IntegerType)()).nullable)
+
+ // CreateArray case invalid indices
+ assert(!ElementAt(array, Literal(0)).nullable)
+ if (ansiEnabled) {
+ assert(!ElementAt(array, Literal(4)).nullable)
+ assert(!ElementAt(array, Literal(-4)).nullable)
+ } else {
+ assert(ElementAt(array, Literal(4)).nullable)
+ assert(ElementAt(array, Literal(-4)).nullable)
+ }
+
+ // GetArrayStructFields case
+ val f1 = StructField("a", IntegerType, nullable = false)
+ val f2 = StructField("b", IntegerType, nullable = true)
+ val structType = StructType(f1 :: f2 :: Nil)
+ val c = AttributeReference("c", structType, nullable = false)()
+ val inputArray1 = CreateArray(c :: Nil)
+ val inputArray1ContainsNull = c.nullable
+ val stArray1 = GetArrayStructFields(inputArray1, f1, 0, 2,
inputArray1ContainsNull)
+ assert(!ElementAt(stArray1, Literal(1)).nullable)
+ assert(!ElementAt(stArray1, Literal(-1)).nullable)
+ val stArray2 = GetArrayStructFields(inputArray1, f2, 1, 2,
inputArray1ContainsNull)
+ assert(ElementAt(stArray2, Literal(1)).nullable)
+ assert(ElementAt(stArray2, Literal(-1)).nullable)
+
+ val d = AttributeReference("d", structType, nullable = true)()
+ val inputArray2 = CreateArray(c :: d :: Nil)
+ val inputArray2ContainsNull = c.nullable || d.nullable
+ val stArray3 = GetArrayStructFields(inputArray2, f1, 0, 2,
inputArray2ContainsNull)
+ assert(!ElementAt(stArray3, Literal(1)).nullable)
+ assert(!ElementAt(stArray3, Literal(-2)).nullable)
+ assert(ElementAt(stArray3, Literal(2)).nullable)
+ assert(ElementAt(stArray3, Literal(-1)).nullable)
+ val stArray4 = GetArrayStructFields(inputArray2, f2, 1, 2,
inputArray2ContainsNull)
+ assert(ElementAt(stArray4, Literal(1)).nullable)
+ assert(ElementAt(stArray4, Literal(-2)).nullable)
+ assert(ElementAt(stArray4, Literal(2)).nullable)
+ assert(ElementAt(stArray4, Literal(-1)).nullable)
+
+ // GetArrayStructFields case invalid indices
+ assert(!ElementAt(stArray3, Literal(0)).nullable)
+ if (ansiEnabled) {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
