HeartSaVioR commented on pull request #30210: URL: https://github.com/apache/spark/pull/30210#issuecomment-726418896
There's no indication I have produced all review comments (while actually I produced all review comments), and review comment author would be the right one to verify whether the review comments are addressed as suggested. I planned to review the new change again today but it's already merged. I see we tend to ask reviewers to see whether they're happy with the last change before merging. At least we "were", and I tend to ensure that, unless reviewers are not responded for days. I'd hope we ensure everyone is happy with the change before merging, otherwise discuss/debate if necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
