HeartSaVioR commented on pull request #30210: URL: https://github.com/apache/spark/pull/30210#issuecomment-726433238
What do you say? I don't say you're missing the comment. I say the confirmation is better to be done by the reviewers who review, not from some other one. The confirmation would only take a day or so (due to the timezone) if the reviewers are quite active. Even you can say "I'll merge in tomorrow if there's no further feedback." to force the delay to a day. You're emphasizing 2 weeks but I can enumerate the PRs which waits for a half of year or even years. The code change is quite small (because the detection logic was there), but given it's breaking backward compatibility, it's not odd request to make a consensus. If the default is false probably we rather concern less. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
