xuanyuanking commented on a change in pull request #30347:
URL: https://github.com/apache/spark/pull/30347#discussion_r524072960
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -414,209 +412,135 @@ class UnsupportedOperationsSuite extends SparkFunSuite {
batchStreamSupported = false,
streamBatchSupported = false)
- // Left outer joins: *-stream not allowed
+ // Left outer, left semi, left anti join: *-stream not allowed
+ Seq((LeftOuter, "LeftOuter join"), (LeftSemi, "LeftSemi join"), (LeftAnti,
"Left anti join"))
Review comment:
I mean at least be consistent for the `name` param here:
`LeftOuter join` `LeftSemi join` and `LeftAnti join`
or
`left outer join` `left simi join` and `left anti join`
Yes, it's too nit and not worth a single commit if there's no further
comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
