Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4129#discussion_r28388461
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala
---
@@ -41,8 +41,20 @@ private[spark] class SparkDeploySchedulerBackend(
private val registrationBarrier = new Semaphore(0)
- private val maxCores = conf.getOption("spark.cores.max").map(_.toInt)
- private val totalExpectedCores = maxCores.getOrElse(0)
+ val maxCores = conf.getOption("spark.cores.max").map(_.toInt)
+ val coreNumPerTask = conf.getInt("spark.task.cpus", 1)
+
+ if (coreNumPerTask < 1) {
+ throw new IllegalArgumentException(
+ s"spark.task.cpus is set to an invalid value $coreNumPerTask")
+ }
--- End diff --
The right place to do this is in `TaskSchedulerImpl`. Also we should be
more specific in the error message what "invalid value" means:
```
"spark.task.cpus" must be greater than 0! (was $coresPerTask)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
