Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4129#discussion_r28388951
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -556,17 +556,18 @@ private[spark] class Master(
// in the queue, then the second app, etc.
if (spreadOutApps) {
// Try to spread out each app among all the nodes, until it has all
its cores
- for (app <- waitingApps if app.coresLeft > 0) {
+ for (app <- waitingApps if app.coresLeft >= app.desc.coreNumPerTask)
{
--- End diff --
We should add a comment here:
```
// Take into account the number of cores the application uses per task
(SPARK-5337)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
