Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4129#discussion_r28388840
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -213,13 +225,13 @@ private[spark] class CoarseMesosSchedulerBackend(
val slaveId = offer.getSlaveId.toString
val mem = getResource(offer.getResourcesList, "mem")
val cpus = getResource(offer.getResourcesList, "cpus").toInt
+ val cpusToUse = math.min(cpus, maxCores - totalCoresAcquired)
--- End diff --
This doesn't handle your second case right? If `cpusToUse` is 5 and
`spark.task.cpus` is 2, then there will be 1 core wasted on the executor. Do we
need another check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
