Github user cfregly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5439#discussion_r28390980
  
    --- Diff: docs/streaming-kinesis-integration.md ---
    @@ -67,6 +67,8 @@ A Kinesis stream can be set up at one of the valid 
Kinesis endpoints with 1 or m
     
        - `[initial position]`: Can be either 
`InitialPositionInStream.TRIM_HORIZON` or `InitialPositionInStream.LATEST` (see 
Kinesis Checkpointing section and Amazon Kinesis API documentation for more 
details).
     
    +   - `[credentials]`: Optional AWS credentials.
    --- End diff --
    
    it's a bit misleading to say this is optional since we still need to 
provide a value (None/null or Some)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to