Github user cfregly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5439#discussion_r28391083
  
    --- Diff: 
extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
 ---
    @@ -131,7 +131,7 @@ public static void main(String[] args) {
             for (int i = 0; i < numStreams; i++) {
               streamsList.add(
                 KinesisUtils.createStream(jssc, streamName, endpointUrl, 
checkpointInterval, 
    -            InitialPositionInStream.LATEST, 
StorageLevel.MEMORY_AND_DISK_2())
    +            InitialPositionInStream.LATEST, 
StorageLevel.MEMORY_AND_DISK_2(), null)
    --- End diff --
    
    another option is to require a non-null value to tighten up the interface - 
DefaultAWSCredentialsProvider() would be recommended, but people can pass in 
their own.
    
    again, please make sure there are no Serializable issues if you go this 
route.  i remember having issues here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to