Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/5510#issuecomment-93287009
  
    Thinking more about this...
    
    Hm, if the semantics are, "build with default hyperparams, overridden by 
any hyperparams set explicitly in `ParamMap`", then an empty `ParamMap` doesn't 
sound like an error. 
    
    Viewed that way, the original behavior sort of makes sense: with no values 
for any key, there is 1 rather than 0 combinations to try: the all-default 
combination. For the same reason that for example `Array[Int]().product` is 1, 
not 0. Sort of.
    
    Should it be an error to build a param grid with no grid at all, maybe? 
that would also resolve this situation.
    
    If the intent of `ParamMap` is that it should have a setting for _all_ 
hyperparameters, then it's an error to build a grid without a range for every 
hyperparameter -- and certainly to build a grid without any at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to