Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5510#issuecomment-93468468
Thinking more, I'm starting to feel like returning 1 empty ParamMap is
better than returning 0 ParamMaps. Basically, I think the natural "unit" grid
should 1 empty ParamMap, rather than 0 ParamMaps. Here are some thoughts:
* Suppose we later add support for users doing cross products between 2
param grids (Array[ParamMap]). Then mathematically, the "unit" grid should be
1 empty ParamMap.
* Users should get the same behavior if they (a) create a "unit" grid and
iterate over it themselves or (b) create a "unit" grid and pass it to
CrossValidator. Currently, the behavior is the same. But if a unit grid is 0
ParamMaps and CrossValidator handles that specially, then the behavior will not
be the same.
I'd vote for adding a log warning but keeping the original behavior of
ParamGridBuilder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
