c21 commented on a change in pull request #30395:
URL: https://github.com/apache/spark/pull/30395#discussion_r532009689
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -411,11 +411,12 @@ class UnsupportedOperationsSuite extends SparkFunSuite
with SQLHelper {
// Full outer joins: only batch-batch is allowed
Review comment:
I agree this is a bit confusing, and I was confused when I looked at the
unit test earlier. The test (`testBinaryOperationInStreamingPlan `) is to check
whether `_.join(_, joinType = _)` supports stream-stream or not. For left
outer/right outer/left semi/full outer, stream-stream join is not supported in
this case as the watermark condition is not defined. See original unit tests
for left outer/right outer/left semi
[here](https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala#L426-L435).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
