HeartSaVioR commented on a change in pull request #30395:
URL: https://github.com/apache/spark/pull/30395#discussion_r532310610
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -411,11 +411,12 @@ class UnsupportedOperationsSuite extends SparkFunSuite
with SQLHelper {
// Full outer joins: only batch-batch is allowed
Review comment:
The comment was explaining for "all cases" of full outer joins. I know
the test is covered but the valid comment becomes no longer valid and we still
leave the comment here without fixing the comment.
I meant like below:
```
// Full outer joins: stream-batch/batch-stream join are not allowed
// stream-stream full outer join is allowed 'conditionally' - see below check
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
