c21 commented on pull request #30395:
URL: https://github.com/apache/spark/pull/30395#issuecomment-735184558


   > FYI, during reviewing I found confusing method names: 
setupWindowedJoinWithRangeCondition / setupWindowedSelfJoin. We should remove 
Windowed there, but not from this PR as these methods exist.
   
   @HeartSaVioR - sounds good, I will submit a separate PR later tomorrow. 
thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to