Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5467#issuecomment-93969770
@jkbradley I think I have addressed all your comments except the
constructor.
How about retaining the present Word2VecModel(Map: [String, Array(Float)])
and converting it internally to Word2VecModel(Map: [String, Int], Matrix) using
something like
this(Map: [String, Int], Matrix) = {
// do map to indexedModel and Matrix conversion
this(indexedModel: Map[String, Int], Matrix)
}
Supplying a Map[String, Int] seems much more intuitive from a user's point
of view,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
