Github user MechCoder commented on the pull request:

    https://github.com/apache/spark/pull/5467#issuecomment-94197937
  
    @jkbradley  Thinking over it again, I'm not sure if it would offer a great 
advantage to do so. If you are talking about preventing this slicing 
(https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala#L408)?
    
    If yes, then even if I prevent this slicing and pass the Matrix, I would 
have to do the slicing again from `Matrix.values` to find the norms 
(https://github.com/apache/spark/pull/5467/files#diff-88f4b62c382b26ef8e856b23f5167ccdR446)
 .
    
    What other advantage did you have in mind?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to