Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/5467#issuecomment-94581278
  
    @MechCoder  That looks correct, except you'll need to call this() 
immediately.  I'd write helper methods for constructing wordIndex and 
wordVectors:
    ```
      private def this(model: Map[String, Array[Float]]) = 
this(buildWordIndex(model), buildWordVectors(model))
    ```
    
    You'll need to add unit tests and stuff too.  Would you actually mind if we 
made this another JIRA and PR?  I'm starting to worry about mission creep.  : )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to