HyukjinKwon commented on a change in pull request #30558:
URL: https://github.com/apache/spark/pull/30558#discussion_r542975368
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -185,6 +185,9 @@ abstract class Optimizer(catalogManager: CatalogManager)
RemoveLiteralFromGroupExpressions,
RemoveRepetitionFromGroupExpressions) :: Nil ++
operatorOptimizationBatch) :+
+ // This batch rewrites data source plans and should be run after the
operator
+ // optimization batch and before any batches that depend on stats.
+ Batch("Data Source Rewrite Rules", Once, dataSourceRewriteRules: _*) :+
Review comment:
So `dataSourceRewriteRules` looks like definitely not the appropriate
name that we should expose out as an API. This is merged to Spark 3.1. Shall we
revert in Spark 3.1 and think about better naming since we all agree with
having a better name? specially considering "Alternatives to Breaking an API"
in https://spark.apache.org/versioning-policy.html.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
