HyukjinKwon commented on a change in pull request #30558:
URL: https://github.com/apache/spark/pull/30558#discussion_r542981738
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -185,6 +185,9 @@ abstract class Optimizer(catalogManager: CatalogManager)
RemoveLiteralFromGroupExpressions,
RemoveRepetitionFromGroupExpressions) :: Nil ++
operatorOptimizationBatch) :+
+ // This batch rewrites data source plans and should be run after the
operator
+ // optimization batch and before any batches that depend on stats.
+ Batch("Data Source Rewrite Rules", Once, dataSourceRewriteRules: _*) :+
Review comment:
@rdblue, it would be great if we can stick to having a good APIs as
discussed and documented in "Alternatives to Breaking an API" in
https://spark.apache.org/versioning-policy.html.
To clarify, I am _not_ suggesting to revert in `master` branch. I am
suggesting to remove in `branch-3.1` alone to have a better designed API out.
Keeping something only because it's useful to people is the exact reason why
Spark happened to have a lot of cruft. We can't just remove them out for legacy
reason and what we discussed in
https://spark.apache.org/versioning-policy.html, but this one is not released
out yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
