AngersZhuuuu commented on a change in pull request #30928:
URL: https://github.com/apache/spark/pull/30928#discussion_r549236608
##########
File path:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
##########
@@ -60,11 +60,11 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
var name: String = null
var childArgs: ArrayBuffer[String] = new ArrayBuffer[String]()
var jars: String = null
- var packages: String = null
- var repositories: String = null
- var ivyRepoPath: String = null
+ var packages: Option[String] = None
Review comment:
> Sorry but why do we bother change this? Looks like there are a lot of
`null`s above too.
Yea, that's why I asked about
https://github.com/apache/spark/pull/30928#issuecomment-751213946
Since want to refactor parameter to use `Option[String]`, but here are just
`String`, so change this place .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
