AngersZhuuuu commented on a change in pull request #30928:
URL: https://github.com/apache/spark/pull/30928#discussion_r549902173
##########
File path:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
##########
@@ -60,11 +60,11 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
var name: String = null
var childArgs: ArrayBuffer[String] = new ArrayBuffer[String]()
var jars: String = null
- var packages: String = null
- var repositories: String = null
- var ivyRepoPath: String = null
+ var packages: Option[String] = None
Review comment:
> I'm neutral on this change, too. I find `xxx: String = null` in many
places of the `core` package and I'm not sure that this partial fix can make
any benefit.
Ok, revert this change. about this.How about current
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
