AngersZhuuuu commented on a change in pull request #30928:
URL: https://github.com/apache/spark/pull/30928#discussion_r549242424
##########
File path:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
##########
@@ -60,11 +60,11 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
var name: String = null
var childArgs: ArrayBuffer[String] = new ArrayBuffer[String]()
var jars: String = null
- var packages: String = null
- var repositories: String = null
- var ivyRepoPath: String = null
+ var packages: Option[String] = None
Review comment:
> `String` vs `null` is a valid way probably in Java context. `Option`
might be preferred since we're in Scala but I wouldn't change it just for this
reason. The gain is small compared to the size of change and potential
maintenance overhead.
So would you prefer to keep current or revert this change and just make it
as Option when use method
```
val resolvedMavenCoordinates =
DependencyUtils.resolveMavenDependencies(
packagesTransitive = true, Option(args.packagesExclusions),
Option(args.packages),
Option(args.repositories), Option(args.ivyRepoPath),
Option(args.ivySettingsPath)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
