jaceklaskowski commented on a change in pull request #31231:
URL: https://github.com/apache/spark/pull/31231#discussion_r559409271
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
##########
@@ -412,4 +414,24 @@ class SparkSessionBuilderSuite extends SparkFunSuite with
BeforeAndAfterEach {
}
assert(!logAppender.loggingEvents.exists(_.getRenderedMessage.contains(msg)))
}
+
+ test("SPARK-34087: ExecutionListenerBus can be removed by user.") {
+ val spark = SparkSession
+ .builder()
+ .master("local")
+ .appName("SPARK-34087")
+ .getOrCreate()
+ (1 to 1000).foreach(_ => {
Review comment:
nit: replace `foreach(_ => {` with `foreach { _ =>`
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##########
@@ -109,6 +109,16 @@ class ExecutionListenerManager private[sql](session:
SparkSession, loadExtension
listenerBus.removeAllListeners()
}
+ /**
+ * Removes [[ExecutionListenerBus]] from LiveListenerBus.queues. people
should call this function
Review comment:
Need rewording IMHO.
"This function should be called..." (no idea what should actually follow.
it's not clear to me by the change)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
