cfmcgrady commented on a change in pull request #31231:
URL: https://github.com/apache/spark/pull/31231#discussion_r559901469
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##########
@@ -109,6 +109,16 @@ class ExecutionListenerManager private[sql](session:
SparkSession, loadExtension
listenerBus.removeAllListeners()
}
+ /**
+ * Removes [[ExecutionListenerBus]] from LiveListenerBus.queues. people
should call this function
+ * when the manager belongs session was removed.
+ */
+ @DeveloperApi
+ def clearListenerBus(): Unit = {
Review comment:
I think it is a good idea to remove the listeners automatically. If I
understand correctly, Spark now has no method to destroy a SparkSession, user
manager session lifecycle by themself, so we can't remove the listener
automatically. Maybe we can put clear listener behavior in
`SparkSession.clearActiveSession()`, but i think it's not a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
