cfmcgrady commented on a change in pull request #31231:
URL: https://github.com/apache/spark/pull/31231#discussion_r559425936
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##########
@@ -109,6 +109,16 @@ class ExecutionListenerManager private[sql](session:
SparkSession, loadExtension
listenerBus.removeAllListeners()
}
+ /**
+ * Removes [[ExecutionListenerBus]] from LiveListenerBus.queues. people
should call this function
Review comment:
`SparkSession.clone()` will create a new `ExecutionListenerBus` and each
`ExecutionListenerBus` reference its belongs session, before this change we
have no method to remove `ExecutionListenerBus`, if we continuously cloning
session from our application, these session/listeners will occur a memory leak.
So we should clear `ExecutionListenerBus` through this method when we remove
the cloned session.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
