jaceklaskowski commented on a change in pull request #31231:
URL: https://github.com/apache/spark/pull/31231#discussion_r561006667
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##########
@@ -109,6 +109,16 @@ class ExecutionListenerManager private[sql](session:
SparkSession, loadExtension
listenerBus.removeAllListeners()
}
+ /**
+ * Removes [[ExecutionListenerBus]] from LiveListenerBus.queues. people
should call this function
Review comment:
Better. What do you think of this?
> Removes [[ExecutionListenerBus]] from LiveListenerBus.queues.
> Each SparkSession has its own listener manager, and this manager won't be
cleared by Spark.
> Developers are expected to call this function (to clean up the listener
manager) while destroying a session
What do you think about a code snippet to help devs understand it even
better? Code like picture says a thousand words :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
