Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5447#issuecomment-95525064
@tsudukim that's true, and that makes this hard to test, since we don't run
on Windows machines. Your code manages to detect whether the test is running on
Windows and change accordingly, so that much is good. The risk is just that a
change breaks the Windows tests and goes unnoticed for a while. This may be a
risk we have to take. Or, you can simply not include the Windows tests since
this change is also primarily about Linux now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
