HeartSaVioR commented on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-782941790
IMHO I wouldn't call it as "invasive" regardless of amount of changes if the change is simple replacement and the replacement is guaranteed to work without changing the behavior. If we are hoping that Scala community takes the decision back before releasing Scala 3 (and even would like to try persuading Scala community) then yes it would be worth to postpone. Otherwise I don't see any difference on "when" we should do this. I agree this is orthogonal with SPARK-25075 - this shouldn't block calling SPARK-25075 as completed, but I'd like to see the change earlier to give end users a signal to NOT use symbol character in their Spark app code. If we feel this change is a big huge to review, probably we could deal with user facing codes and docs (e.g. examples) first, and deal with others later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
