mallman commented on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-782954129
> I would say this PR is the right thing to do. I've reconsidered and changed my opinion. > Do we really need this at Apache Spark 3.2.0? If we want to support Scala 2.13 for Spark 3.2.0, I don't think this change is necessary. > Can we do this invasive change after 3.2.0 release? Yes, that follows from above. Further, I think it's preferable (see below). > Apache Spark is living with Java11 warnings, too. Yup. So is a lot of code out there. I've seen it. I've used it. It will be around a while. There's a lot of legacy code that was built with Java 8 special magic. I think this legacy tends to influence language developers decisions. If nobody used the unsupported features of Java 8 that are deprecated in Java 11, they would be compile errors not warnings. The scope and size of this PR is significant: 170 files and 7,225 lines. I think its necessity is predicated on some assumptions about the future, such as the removal of this feature in Scala 3 or Spark's support for Scala 3. I suggest postponing this effort until it becomes a necessity. Also, if we express personal preference, I will say I rather like the ' syntax. I think it's an elegant, powerful syntax well-suited to certain use cases. It can also be abused terribly, but my experience using it with Spark SQL has been positive. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
