Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5377#discussion_r29121411
--- Diff:
network/common/src/main/java/org/apache/spark/network/sasl/SaslRpcHandler.java
---
@@ -46,19 +47,30 @@
/** Class which provides secret keys which are shared by server and
client on a per-app basis. */
private final SecretKeyHolder secretKeyHolder;
- /** Maps each channel to its SASL authentication state. */
- private final ConcurrentMap<TransportClient, SparkSaslServer>
channelAuthenticationMap;
+ /** The client channel. */
+ private final Channel channel;
- public SaslRpcHandler(RpcHandler delegate, SecretKeyHolder
secretKeyHolder) {
+ private final TransportConf conf;
+
+ private SparkSaslServer saslServer;
+ private boolean isComplete;
+
+ SaslRpcHandler(
+ TransportConf conf,
+ Channel channel,
+ RpcHandler delegate,
+ SecretKeyHolder secretKeyHolder) {
+ this.conf = conf;
--- End diff --
nit: reorder fields to follow same order as constructor parameters
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
